Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial: Make build environment definitions linkable #1274

Merged
merged 3 commits into from
Feb 4, 2025
Merged

editorial: Make build environment definitions linkable #1274

merged 3 commits into from
Feb 4, 2025

Conversation

marcelamelara
Copy link
Contributor

Fixes #1177 and #1197 .

@marcelamelara marcelamelara added the build-environment-track Issues/PRs related to the SLSA BuildEnv track label Jan 8, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for slsa ready!

Name Link
🔨 Latest commit ff18705
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/67a103731078a50008357450
😎 Deploy Preview https://deploy-preview-1274--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcelamelara marcelamelara marked this pull request as ready for review January 8, 2025 22:04
@marcelamelara marcelamelara linked an issue Jan 8, 2025 that may be closed by this pull request
Add reference to TPM 2.0 spec defining "Quote" #1197
Closed
lehors
lehors approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelamelara marcelamelara changed the title content: Make build environment definitions linkable editorial: Make build environment definitions linkable Feb 3, 2025
arewm
arewm approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to merge after rebasing on the new layout to ensure compatibility.

@marcelamelara marcelamelara force-pushed the add-links-build-env-model branch from c7ed10b to ff18705 Compare February 3, 2025 17:57
@marcelamelara marcelamelara merged commit 8aa6c73 into slsa-framework:main Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlieberman85 mlieberman85 mlieberman85 approved these changes

@lehors lehors lehors approved these changes

@arewm arewm arewm approved these changes

Assignees
No one assigned
Labels
build-environment-track Issues/PRs related to the SLSA BuildEnv track
Projects
Issue triage
Status: ✅ Done
SLSA Attested Build Environment Track
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reference to TPM 2.0 spec defining "Quote" Link build environment terms to their definitions
4 participants
@marcelamelara @mlieberman85 @lehors @arewm